Skip to content

Conversation

@firestar300
Copy link
Contributor

Afin de gérer les attributs defer ou async sur les balises <script>, j'ai modifié le comportement de la fonction register_script pour prendre en compte ce paramètre.

Cf https://make.wordpress.org/core/2023/07/14/registering-scripts-with-async-and-defer-attributes-in-wordpress-6-3/

@firestar300 firestar300 changed the title Modification du paramètre (bool) $in_footer => (array) $strategy pour wp_register_script Modification du paramètre (bool) $in_footer=> (array) $strategy pour wp_register_script Feb 4, 2025
@firestar300 firestar300 changed the title Modification du paramètre (bool) $in_footer=> (array) $strategy pour wp_register_script Modification du paramètre (bool) $in_footer => (array) $strategy pour wp_register_script Feb 4, 2025
n-langle
n-langle previously approved these changes Feb 5, 2025
@Rahe
Copy link
Member

Rahe commented Feb 6, 2025

En modifiant ça, il faut supprimer la classe inc/Services/Assets_JS_Async.php et ce qui y est relié, puisque le coeur le fait tout seul.

@firestar300
Copy link
Contributor Author

En modifiant ça, il faut supprimer la classe inc/Services/Assets_JS_Async.php et ce qui y est relié, puisque le coeur le fait tout seul.

J'ai appliqué tes retours.

@firestar300 firestar300 requested review from Rahe and n-langle February 6, 2025 11:19
@firestar300 firestar300 merged commit 9c42847 into master Feb 10, 2025
2 of 3 checks passed
@firestar300 firestar300 deleted the feat/register_script_strategy branch February 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants